mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49571: Added a benchmark test for allocations.
Date Fri, 05 Aug 2016 22:04:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144996
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3490)
<https://reviews.apache.org/r/49571/#comment211150>

    Suggest use `OfferedResources` here, please refer to the comments here https://reviews.apache.org/r/50677/
as a reference. I also posted a patch https://reviews.apache.org/r/50868/ here to make `SuppressOffers`
benchmark test using `OfferedResources` but not `Allocation`.



src/tests/hierarchical_allocator_tests.cpp (line 3497)
<https://reviews.apache.org/r/49571/#comment211151>

    s/allocations/offers
    
    `offers` would be a better name as here we are using benchmark test to simulate some `offer`
operations.



src/tests/hierarchical_allocator_tests.cpp (lines 3516 - 3517)
<https://reviews.apache.org/r/49571/#comment211152>

    This can be simplified as following:
    
    ```
    initialize(master::Flags(), offerCallback);
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 3522 - 3531)
<https://reviews.apache.org/r/49571/#comment211153>

    Can you please add the time elapse for adding those frameworks just like other benchmark
tests in allocator?



src/tests/hierarchical_allocator_tests.cpp (line 3532)
<https://reviews.apache.org/r/49571/#comment211156>

    You are losing `Clock::settle();` here, we need to wait till all `addFramework` operations
to be processed.



src/tests/hierarchical_allocator_tests.cpp (lines 3538 - 3539)
<https://reviews.apache.org/r/49571/#comment211154>

    new line here



src/tests/hierarchical_allocator_tests.cpp (line 3540)
<https://reviews.apache.org/r/49571/#comment211159>

    remove the `;` for `disk(test):1024;`, we do not need it in the end.



src/tests/hierarchical_allocator_tests.cpp (lines 3548 - 3578)
<https://reviews.apache.org/r/49571/#comment211157>

    Same as `addFramework`, it is better also add the time elapse for the `addSlave` here.



src/tests/hierarchical_allocator_tests.cpp (line 3572)
<https://reviews.apache.org/r/49571/#comment211155>

    s/slave/agent as you are already using `agent` for some variables here



src/tests/hierarchical_allocator_tests.cpp (line 3608)
<https://reviews.apache.org/r/49571/#comment211158>

    s/allocate/allocate() to keep consistent with other benchmark test.


- Guangya Liu


On 八月 4, 2016, 8:26 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
> 
> (Updated 八月 4, 2016, 8:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
>     https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
>     resources; and offers from every other alternate slave contains
>     a shared resource.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==================================
> Support of shared resources has a small impact on runtime performance in allocations.
Also, there is no visible impact in performance when shared resources are added in the tests.
> 
> With the patch (and no shared resources)
> ----------------------------------------
> round 0 allocate took 3.3096secs to make 2000 offers
> round 50 allocate took 3.302636secs to make 2000 offers
> round 100 allocate took 3.321002secs to make 2000 offers
> round 150 allocate took 3.305755secs to make 2000 offers
> round 199 allocate took 3.305825secs to make 2000 offers
> 
> With the patch (and shared resources on all agents)
> ---------------------------------------------------
> round 0 allocate took 3.361138secs to make 2000 offers
> round 50 allocate took 3.375249secs to make 2000 offers
> round 100 allocate took 3.36454secs to make 2000 offers
> round 150 allocate took 3.366206secs to make 2000 offers
> round 199 allocate took 3.365199secs to make 2000 offers
> 
> With the patch (and shared resources on alternate agents)
> ---------------------------------------------------------
> round 0 allocate took 3.335685secs to make 2000 offers
> round 50 allocate took 3.341063secs to make 2000 offers
> round 100 allocate took 3.341839secs to make 2000 offers
> round 150 allocate took 3.335622secs to make 2000 offers
> round 199 allocate took 3.337968secs to make 2000 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD supported)
> ---------------------------------------------------------------------------------
> round 0 allocate took 3.00921secs to make 2000 offers
> round 50 allocate took 3.006498secs to make 2000 offers
> round 100 allocate took 3.004949secs to make 2000 offers
> round 150 allocate took 3.00702secs to make 2000 offers
> round 199 allocate took 3.00633secs to make 2000 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message