mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 50854: Resolved C++11-related TODO in zookeeper/group.cpp.
Date Fri, 05 Aug 2016 18:19:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50854/#review144965
-----------------------------------------------------------


Ship it!




Just a nit, I'll fix it when committing.


src/zookeeper/group.cpp (line 113)
<https://reviews.apache.org/r/50854/#comment211118>

    Nit: now that we don't need to disambiguate between the member `sessionTimeout` and the
argument, we can just name the argument `sessionTimeout`.


- Jiang Yan Xu


On Aug. 5, 2016, 8:30 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50854/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 8:30 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Resolved C++11-related TODO in zookeeper/group.cpp.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.cpp 2c1589b9fd516f14f15149cebcd399c9bf774dd5 
> 
> Diff: https://reviews.apache.org/r/50854/diff/
> 
> 
> Testing
> -------
> 
> `make check` in OS X, Centos 7, Centos 6, Debian 8, Fedora 23, Ubuntu 14, Ubuntu 12,
Ubuntu 15, Ubuntu 16
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message