mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 50845: Added `unreachable_time` to TaskStatus.
Date Fri, 05 Aug 2016 10:39:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50845/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-5949
    https://issues.apache.org/jira/browse/MESOS-5949


Repository: mesos


Description
-------

This field contains the time at which the master marked an agent as
unreachable. It will only be set for status updates (including
reconciliation updates) that describe tasks running on unreachable
(e.g., partitioned) agents.

The intent is to help frameworks decide how to handle tasks running on
partitioned agents: since the framework might have missed the initial
TASK_LOST/TASK_UNREACHABLE status update (e.g., due to framework
downtime/failover), it might otherwise be difficult for frameworks to
determine how long an agent has been partitioned.

This unreachable timestamp is stored in the registry and loaded as part
of master recovery.


Diffs
-----

  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
  include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
  src/common/protobuf_utils.hpp 3324838f0a54491024b3e26ddf38afbfad31b8e4 
  src/common/protobuf_utils.cpp 8c4a7264080385789157703b05b42716fb0563b3 
  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 92595097c8f26675aee122c8a11366262534db64 
  src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 
  src/tests/reconciliation_tests.cpp 492560c430eba45e3a9f7a767ee761dfa0cacb05 
  src/tests/registrar_tests.cpp ba7c66ff83f09d68fb5324a3f85d2875068a35a6 

Diff: https://reviews.apache.org/r/50845/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message