mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yubo Li <liyub...@cn.ibm.com>
Subject Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.
Date Fri, 05 Aug 2016 08:21:19 GMT


> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, lines 81-141
> > <https://reviews.apache.org/r/50127/diff/3/?file=1460569#file1460569line81>
> >
> >     Seems those are from docker_containerizer_test.cpp, I think that we do not need
to copy the code here but add the test case to docker_containerizer_test.cpp as you want to
test docker containerizer.

Yes, it's copyed from `docker_containerizer_test.cpp`. In my original idea, I want to put
all Nvidia GPU related tests in the single file `nvidia_gpu_isolator_tests.cpp`. Do you think
it's better to put this test to `docker_containerizer_test.cpp`?

Moved to `docker_containerizer_test.cpp`


> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, line 745
> > <https://reviews.apache.org/r/50127/diff/3/?file=1460569#file1460569line745>
> >
> >     This will cause test failed if the system do not have nvml.
> >     
> >     Can you please add a filter to filter out the test if the nvml is not avaiable?
> >     
> >     You can refer to https://github.com/apache/mesos/blob/master/src/tests/environment.cpp#L279-L313
for how to add a filter.

I see. I modified the test name to `ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpu` so that it is filtered
by both `NVIDIA_GPU_` and `DOCKER_`.


> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, line 758
> > <https://reviews.apache.org/r/50127/diff/3/?file=1460569#file1460569line758>
> >
> >     Do you need this with docker containerizer?

Currently we need. When I remove this line, the test reports error:
resources: '--nvidia_gpus_devices' can only be specified if the `--isolation` flag contains
'gpu/nvidia'.

Actually, docker containerizer does not need `--isolation`, but currently `--nvidia_gpus_devices`
forces us to do this. We would talk with Ben and Kevin to remove this retriction for docker
containerizer soon.


- Yubo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review144762
-----------------------------------------------------------


On 八月 2, 2016, 2:23 p.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 八月 2, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message