mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <>
Subject Re: Review Request 50491: Added PIDGroup to libprocess.
Date Fri, 05 Aug 2016 08:16:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 5, 2016, 8:16 a.m.)

Review request for mesos and Joseph Wu.

Summary (updated)

Added PIDGroup to libprocess.

Bugs: MESOS-5828

Repository: mesos

Description (updated)

Log network is not specific to replicated log and the name 'network'
is also confusing. Therefore, PIDGroup is added to libprocess as a
replacement for network. This is a step towards modularizing the
PIDGroup abstraction alongside the `MasterContender` and

Note: The PIDGroup abstraction is a component that discovers all masters
in the group; whereas the `MasterDetector` only discovers the leader
of the group. Both are necessary for the replicated log.

Diffs (updated)

  3rdparty/libprocess/ 020b0e1e4c49805a3c7a61b308d897fc82f5e0ce 
  3rdparty/libprocess/include/ a27e9f7aaa2b45139d4eb95f365d8b2041d7aad2 
  3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
  3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/pid_group_tests.cpp PRE-CREATION 



see the end of review chain.


Jay Guo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message