mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.
Date Fri, 05 Aug 2016 07:49:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50741/#review144890
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50739, 50741]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 9:57 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50741/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-5986
>     https://issues.apache.org/jira/browse/MESOS-5986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The lambda placed on the event loop by the libevent SSL
> socket's `send()` method previously used a `CHECK` to
> ensure that the socket's `send_request` member was not
> `nullptr`. This patch removes this check and replaces it
> with a log message, since `send_request` may become
> `nullptr` any time the socket receives an EOF or ERROR
> event.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 97af3c25a350f4490f526e096678bb1eab066174

> 
> Diff: https://reviews.apache.org/r/50741/diff/
> 
> 
> Testing
> -------
> 
> Ran a modified test case repeatedly to see this message printed when an SSL socket receives
an EOF at the appropriate time.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message