mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 50827: Windows: Disable modules tests and related helpers.
Date Fri, 05 Aug 2016 00:41:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50827/
-----------------------------------------------------------

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and Joris Van Remoortere.


Bugs: MESOS-5994
    https://issues.apache.org/jira/browse/MESOS-5994


Repository: mesos


Description
-------

Building and linking modules has some extra challenges on Windows
(see MESOS-5994).

This patch #ifdef's some module-specific tests on Windows.
NOTE: Most module tests are already parameterized to run the same code,
once as a built-in class and once as a module.


Diffs
-----

  src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd 
  src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
  src/tests/containerizer/isolator_tests.cpp 488747347f71a6a1bb6bc01477143d077d4fd3eb 
  src/tests/cram_md5_authentication_tests.cpp 56c249f48a09e86e1652362b54dca1fea5fc448b 
  src/tests/http_authentication_tests.cpp e73f21f7bd5ebb776ce5e950e1035182b32018ad 
  src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
  src/tests/master_authorization_tests.cpp e43b264b9f67d4cd965aee143cc42a1034ac9952 
  src/tests/slave_authorization_tests.cpp 6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 

Diff: https://reviews.apache.org/r/50827/diff/


Testing
-------

make check (OSX)

TODO: Test this on Linux and Windows.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message