mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49571: Added a benchmark test for allocations.
Date Fri, 05 Aug 2016 00:27:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144852
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45960, 45961, 45962, 45963, 45964, 45966, 45967, 49571]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 8:26 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 8:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
>     https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
>     resources; and offers from every other alternate slave contains
>     a shared resource.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==================================
> Support of shared resources has a small impact on runtime performance in allocations.
Also, there is no visible impact in performance when shared resources are added in the tests.
> 
> With the patch (and no shared resources)
> ----------------------------------------
> round 0 allocate took 3.3096secs to make 2000 offers
> round 50 allocate took 3.302636secs to make 2000 offers
> round 100 allocate took 3.321002secs to make 2000 offers
> round 150 allocate took 3.305755secs to make 2000 offers
> round 199 allocate took 3.305825secs to make 2000 offers
> 
> With the patch (and shared resources on all agents)
> ---------------------------------------------------
> round 0 allocate took 3.361138secs to make 2000 offers
> round 50 allocate took 3.375249secs to make 2000 offers
> round 100 allocate took 3.36454secs to make 2000 offers
> round 150 allocate took 3.366206secs to make 2000 offers
> round 199 allocate took 3.365199secs to make 2000 offers
> 
> With the patch (and shared resources on alternate agents)
> ---------------------------------------------------------
> round 0 allocate took 3.335685secs to make 2000 offers
> round 50 allocate took 3.341063secs to make 2000 offers
> round 100 allocate took 3.341839secs to make 2000 offers
> round 150 allocate took 3.335622secs to make 2000 offers
> round 199 allocate took 3.337968secs to make 2000 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD supported)
> ---------------------------------------------------------------------------------
> round 0 allocate took 3.00921secs to make 2000 offers
> round 50 allocate took 3.006498secs to make 2000 offers
> round 100 allocate took 3.004949secs to make 2000 offers
> round 150 allocate took 3.00702secs to make 2000 offers
> round 199 allocate took 3.00633secs to make 2000 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message