-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50741/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-5986
https://issues.apache.org/jira/browse/MESOS-5986
Repository: mesos
Description
-------
The lambda placed on the event loop by the libevent SSL
socket's `send()` method previously used a `CHECK` to
ensure that the socket's `send_request` member was not
`nullptr`. This patch removes this check and replaces it
with a log message, since `send_request` may become
`nullptr` any time the socket receives an EOF or ERROR
event.
Diffs
-----
3rdparty/libprocess/src/libevent_ssl_socket.cpp 97af3c25a350f4490f526e096678bb1eab066174
Diff: https://reviews.apache.org/r/50741/diff/
Testing
-------
Ran a modified test case repeatedly to see this message printed when an SSL socket receives
an EOF at the appropriate time. Also ran the test contained in
Thanks,
Greg Mann
|