mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.
Date Wed, 03 Aug 2016 19:13:54 GMT


> On July 12, 2016, 4:40 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 141
> > <https://reviews.apache.org/r/49736/diff/1/?file=1438177#file1438177line141>
> >
> >     This probably won't work on Windows. You will notice that for (_e.g._) `HTTP_PARSER_PATCH_CMD`,
we have something like this instead of `PATCH_CMD`:
> >     
> >     ```
> >       set(HTTP_PARSER_PATCH_CMD ${PATCHEXE_LOCATION} --binary -p1 < ${MESOS_3RDPARTY_BIN}/http-parser-${HTTP_PARSER_VERSION}.patch)
> >     ```
> >     
> >     This is pretty unfortuante and as I look at this file, it seems like we're not
patching a lot of the libraries. This is probably my doing. #clowntown I've filed an issue
to make sure we follow up on this: MESOS-5835

There is actually a newer version of elfio that was just released which has my patches merged
in. Instead of dealing with this, we should just upgrade to the newer elfio and avoid the
patch altogether.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49736/#review141913
-----------------------------------------------------------


On Aug. 3, 2016, 4:21 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49736/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 4:21 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5979
>     https://issues.apache.org/jira/browse/MESOS-5979
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt a7ae76a40fcf5c6d6c9dc86daaa7524c220980dd 
> 
> Diff: https://reviews.apache.org/r/49736/diff/
> 
> 
> Testing
> -------
> 
> $ cmake ..
> $ make -j
> $ make -j check
> 
> Manually inspected: `3rdparty/elfio-3.1/src/elfio-3.1/elfio/elfio_note.hpp`
> and saw that the patch is applied.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message