mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 49862: Changed libmesos from static library to a shared library.
Date Wed, 03 Aug 2016 16:40:04 GMT


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake, line 51
> > <https://reviews.apache.org/r/49862/diff/10/?file=1447565#file1447565line51>
> >
> >     You're right to split this out, but just for my own education, was there a specific
reason you did it?

The leveldb shared library will be used in this case.


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/CMakeLists.txt, line 490
> > <https://reviews.apache.org/r/49862/diff/10/?file=1447567#file1447567line490>
> >
> >     Hmm, is this required? It should be `ON` by default for shared libraries, no?

the -fPIC is added and so this should not be required anymore. I think we should prefer to
use this over -fPIC to be not compiler specific?


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/slave/cmake/SlaveConfigure.cmake, line 70
> > <https://reviews.apache.org/r/49862/diff/10/?file=1447569#file1447569line70>
> >
> >     Hmm. Can you talk a bit about why we're adding this here? The agent doesn't
depend on leveldb, right? Only the master does?
> >     
> >     I'm just trying to think about how we actually want to add this. Historically
there has been some ambition to write this in a way that we can get rid of libmesos and split
it up into libagent and libmaster. If we maintain the agent dependencies as separated from
the master dependencies, we will get some duplication in the shared dependencies, but it will
also be easier (hopefully) to reason about what depends on what.
> >     
> >     What do you think?

Refactoring is a good idea, I think we can come up with mesoscommon, mesosmaster and mesosagent
as three different libraries. I prefer not to handle this right now.


- Srinivas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144432
-----------------------------------------------------------


On Aug. 2, 2016, 3:35 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8

>   3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6

>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/master/cmake/MasterConfigure.cmake 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message