mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.
Date Wed, 03 Aug 2016 12:55:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50639/#review144609
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:54 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50639/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
>     https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made all Actor IDs contain only lower case letters and dashes (not
> underscores).
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp 236de252192c4875eb76bc91e9aea1df331bcad7

>   src/authentication/cram_md5/authenticator.cpp 4ec15680b236704c89c9c8b24758797ea6a3dd03

>   src/executor/v0_v1executor.cpp cd1c59016590383b9b57f14da54165b75b441883 
> 
> Diff: https://reviews.apache.org/r/50639/diff/
> 
> 
> Testing
> -------
> 
> `make check` in OS X and various linux distribution, checked the output of `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message