mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 50519: Made libprocess Actor IDs consistent.
Date Wed, 03 Aug 2016 12:55:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50519/#review144608
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:50 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50519/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
>     https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enforced the following actor ID schema in libprocess:
> 
> - Actor IDs contain only lowercase characters, dashes or underscores.
> - The ID of an actor that is exposed to libprocess users, via a route/
>   associated to an endpoint uses dashes as word separator, e.g., `help`.
> - The ID of an actor internal to libprocess, with not associated
>   route/endpoint, must be enclosed in double quotes and use underscores
>   instead of dashes as word separator, e.g.,
>   `__authentication_router__`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/authenticator_manager.cpp 7def832147df01ed51e642f8baf1216590745fdf

>   3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 
> 
> Diff: https://reviews.apache.org/r/50519/diff/
> 
> 
> Testing
> -------
> 
> `make check` in OS X and various linux distribution, checked the output of `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message