-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144596
-----------------------------------------------------------
Patch looks great!
Reviews applied: [50570, 50609]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2016, 11:04 p.m.)
>
>
> Review request for mesos, Jie Yu and Pierre Cheynier.
>
>
> Bugs: MESOS-5928
> https://issues.apache.org/jira/browse/MESOS-5928
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
>
>
> Diffs
> -----
>
> src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7
> src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10
>
> Diff: https://reviews.apache.org/r/50609/diff/
>
>
> Testing
> -------
>
> Ran the mesos agent and master binaries with and without the '--version' flag to verify
correct behavior and return code.
>
>
> Thanks,
>
> Greg Mann
>
>
|