mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.
Date Wed, 03 Aug 2016 01:50:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50732/
-----------------------------------------------------------

(Updated Aug. 3, 2016, 1:50 a.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Changes
-------

Updated comment and a minor tweak.


Bugs: MESOS-5972
    https://issues.apache.org/jira/browse/MESOS-5972


Repository: mesos


Description
-------

Incase of shared resources, the Resource_ object is removed if the
shared count is <= 0, and for non-shared resources, it is removed
if the scalar value is <= 0.


Diffs (updated)
-----

  src/common/resources.cpp 7b52c72534cca55185c1df2257b48cb85c49f65c 
  src/v1/resources.cpp d27c1a24c8e3de40d47cecac0e4528908a39ba52 

Diff: https://reviews.apache.org/r/50732/diff/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message