mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 50719: Supported scratch containers in Unified Containerizer.
Date Tue, 02 Aug 2016 23:44:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50719/
-----------------------------------------------------------

(Updated Aug. 2, 2016, 4:44 p.m.)


Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen, and Jiang Yan
Xu.


Bugs: MESOS-5927
    https://issues.apache.org/jira/browse/MESOS-5927


Repository: mesos


Description
-------

Before this patch, we are assuming the 'tmpfs' mount point '/tmp'
always exist in the container's new rootfs. However, this is not
true. For the scratch container (which is a common case), '/tmp'
may not exist, and there may only be an executable binary in the
new rootfs. So we need to create the mount point for 'tmpfs' in
fs::enter().

However, this change may break some cases using the bind backend,
because we are not able the create the '/tmp' mount point in a
read-only filesystem. So we require users to make sure the
directory '/tmp' must already exist in their single layer scratch
images for the following reasons:
  1. For most cases, when operators prefer using the bind backend,
     the single-layer images are usually large in size, and '/tmp'
     exists in the rootfs.
  2. For scratch images, most of them contain more than one layer,
     which means the bind backend cannot be used in those cases.
     So we can create the '/tmp' mount point if it does not exist.
  3. If this is strictly a single layer scratch image, it is
     reasonable that we require users to make sure the mount point
     '/tmp' existed in the image rootfs if they are using the bind
     backend, because we already require the sandbox mount point
     to be existed in those iamges.


Diffs (updated)
-----

  src/linux/fs.cpp 27d322c759b6ef9ea17b371e7013cace926bff47 

Diff: https://reviews.apache.org/r/50719/diff/


Testing
-------

make check

Manually tested using single-layered scratch image `hello-seattle` from local puller (the
one fetched from registry puller is a two-layer image due to dockerhub server redirection)
and copy backend.

Other scratch image like hello-world is also tested.


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message