mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.
Date Tue, 02 Aug 2016 23:05:29 GMT


> On Aug. 2, 2016, 6:04 p.m., Vinod Kone wrote:
> > src/master/main.cpp, lines 220-223
> > <https://reviews.apache.org/r/50609/diff/2/?file=1460641#file1460641line220>
> >
> >     shouldn't this be moved up above the load error as well?

Sure thing - I was going to only address the '--version' flag in this patch, but since it's
a small change I think there's no harm in including this here.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144517
-----------------------------------------------------------


On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Pierre Cheynier.
> 
> 
> Bugs: MESOS-5928
>     https://issues.apache.org/jira/browse/MESOS-5928
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
>   src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
> 
> Diff: https://reviews.apache.org/r/50609/diff/
> 
> 
> Testing
> -------
> 
> Ran the mesos agent and master binaries with and without the '--version' flag to verify
correct behavior and return code.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message