mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.
Date Tue, 02 Aug 2016 23:04:54 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 2, 2016, 11:04 p.m.)

Review request for mesos, Jie Yu and Pierre Cheynier.


Addressed comment.

Bugs: MESOS-5928

Repository: mesos


The recent removal of the agent's default `work_dir`
requires us to check for the presence of the `--version`
flag before we check for errors in flag loading; this
patch makes that change, and also moves the
corresponding code in the master for consistency.

Diffs (updated)

  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 



Ran the mesos agent and master binaries with and without the '--version' flag to verify correct
behavior and return code.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message