mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50717: Fixed `clean-python` Makefile target.
Date Tue, 02 Aug 2016 21:36:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50717/#review144531
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Aug. 2, 2016, 9:30 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50717/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 9:30 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Vinod Kone.
> 
> 
> Bugs: MESOS-5958
>     https://issues.apache.org/jira/browse/MESOS-5958
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Our usage of `find ... -exec` did not take into account the order of
> operations in `find`.  The placement of `-exec` at the end meant that
> only the `*.egg-info` files were being deleted.
> 
> Adding parentheses around all the `-o` operators fixes what is being
> deleted.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5eabc331579155df9011ade4489aad30b7f5bfe7 
> 
> Diff: https://reviews.apache.org/r/50717/diff/
> 
> 
> Testing
> -------
> 
> make distcheck (CentOS 7)
> 
> Confirmed that the build succeeds without complaining about remaining files.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message