mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 50717: Fixed `clean-python` Makefile target.
Date Tue, 02 Aug 2016 21:30:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50717/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Vinod Kone.


Bugs: MESOS-5958
    https://issues.apache.org/jira/browse/MESOS-5958


Repository: mesos


Description
-------

Our usage of `find ... -exec` did not take into account the order of
operations in `find`.  The placement of `-exec` at the end meant that
only the `*.egg-info` files were being deleted.

Adding parentheses around all the `-o` operators fixes what is being
deleted.


Diffs
-----

  src/Makefile.am 5eabc331579155df9011ade4489aad30b7f5bfe7 

Diff: https://reviews.apache.org/r/50717/diff/


Testing
-------

make distcheck (CentOS 7)

Confirmed that the build succeeds without complaining about remaining files.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message