mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49851: Implemented `MemorySubsystem`.
Date Tue, 02 Aug 2016 18:04:39 GMT


> On July 27, 2016, 2:05 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494
> > <https://reviews.apache.org/r/49851/diff/5/?file=1453262#file1453262line494>
> >
> >     How do we recover this field `updatedLimit`? I mean during agent recovery, `updatedLimit`
of each Info will be reset to `false`, right? But I think that is not correct.

I think this problem exists at `mem.cpp` as well, and update the limit twice here does not
bring problems here. So I drop this. Feel free to reopen this if you think it would bring
problems here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review143517
-----------------------------------------------------------


On Aug. 2, 2016, 5:48 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
>     https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp b191b2a52a9645fc902a35ed52909b2142f0b4c0

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 179eb070d9621348bd7fa7d9a093a857ff0f2855

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41

> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message