mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.
Date Tue, 02 Aug 2016 15:37:12 GMT


> On July 12, 2016, 5:11 a.m., Alex Clemmer wrote:
> > src/tests/CMakeLists.txt, line 52
> > <https://reviews.apache.org/r/49921/diff/1/?file=1441647#file1441647line52>
> >
> >     Is this review relevant anymore? In #49688 it looks like we're using a much
more recent version of this file, and I don't see un-commenting these files as part of the
diff?
> >     
> >     Based on what I see here, it seems like we should probably discard this review
and/or merge it with that last one.
> >     
> >     Thoughts?

This is where the tests are enabled as we agreed this way.


- Srinivas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49921/#review141847
-----------------------------------------------------------


On July 16, 2016, 8:47 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49921/
> -----------------------------------------------------------
> 
> (Updated July 16, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed mesos tests to run 723 test on Unix.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 493b6dbd28945332fbda2d3172018e109e73235a 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/MesosTestsConfigure.cmake caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf

> 
> Diff: https://reviews.apache.org/r/49921/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make
> src/tests/mesos-tests  (runs 723 tests with no failures)
> I did not enable any module that has even a single failue. There are many more tests
that are passing.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message