mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 50513: Added missing process IDs in libprocess.
Date Tue, 02 Aug 2016 13:53:05 GMT


> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/sequence.hpp, line 66
> > <https://reviews.apache.org/r/50513/diff/1/?file=1455329#file1455329line66>
> >
> >     Why do you treat `Sequence` not like other processes in this patch?
> >     
> >     I see that you also changed `Sequence` instances are contrsucted, but maybe
it makes more sence it get an optional suffix here? By default the id is just `seuqence` and
if suffix is passed, it will be something like `sequence-authentications`. Also, maybe it
makes sense to extact `Sequence` update into a separate RR?

Created a separate RR with the `Sequence` change.


> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/authenticator.cpp, line 57
> > <https://reviews.apache.org/r/50513/diff/1/?file=1455330#file1455330line57>
> >
> >     Why this one is enclosed in underscores?

Added the naming schema to the commit description.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/#review144082
-----------------------------------------------------------


On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50513/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
>     https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After this change, all libprocess actors should have a distinguishable
> ID, making it possible to match the logging output or the output of
> the "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc

>   3rdparty/libprocess/include/process/protobuf.hpp 78ff40ed64c4313dd9daddcf96e1447ad015c734

>   3rdparty/libprocess/include/process/run.hpp d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f

>   3rdparty/libprocess/src/authenticator.cpp 55e8558a5272cb0447ad9268ad9c7f27e2f30385

>   3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50513/diff/
> 
> 
> Testing
> -------
> 
> `make check` in OS X and various linux distribution.
> 
> I also looked at the output of the `__process__` endpoint. After this change, some of
the unidentifiable processes have a nicer id now. The goal of this review chain is to give
all processes there an identifiable ID.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message