-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50519/
-----------------------------------------------------------
(Updated Aug. 2, 2016, 1:50 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Rebase + new description + caught one more ID.
Summary (updated)
-----------------
Made libprocess Actor IDs consistent.
Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917
Repository: mesos
Description (updated)
-------
Enforced the following actor ID schema in libprocess:
- Actor IDs contain only lowercase characters, dashes or underscores.
- The ID of an actor that is exposed to libprocess users, via a route/
associated to an endpoint uses dashes as word separator, e.g., `help`.
- The ID of an actor internal to libprocess, with not associated
route/endpoint, must be enclosed in double quotes and use underscores
instead of dashes as word separator, e.g.,
`__authentication_router__`.
Diffs (updated)
-----
3rdparty/libprocess/src/authenticator_manager.cpp 7def832147df01ed51e642f8baf1216590745fdf
3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705
Diff: https://reviews.apache.org/r/50519/diff/
Testing
-------
`make check` in OS X and various linux distribution, checked the output of `__processes__`.
Thanks,
Gastón Kleiman
|