mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 50643: Implemented `CgroupsIsolatorProcess::finalize`.
Date Tue, 02 Aug 2016 02:47:18 GMT


> On Aug. 1, 2016, 1:52 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 135
> > <https://reviews.apache.org/r/50643/diff/1/?file=1458770#file1458770line135>
> >
> >     Just wondering when this method will be called?
> 
> haosdent huang wrote:
>     When `terminate()`, the `Process` would receive a `TerminateEvent` env, then this
method would be called. https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L3539-L3542

Yeah, I know sending `TerminateEvent` will trigger `finalize()` to be called. I was just wondering
when this event will be sent to `CgroupsIsolatorProcess`. After checking more code, it seems
it will evetually be triggered when agent is shutdown. Thanks.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50643/#review144304
-----------------------------------------------------------


On Aug. 1, 2016, 1:48 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50643/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::finalize`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 422b4653fc3cb3d14c94b93ff456625fc59fbb27

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp bd20631a9650cf84e99c6489b2e92bc40ed764ca

> 
> Diff: https://reviews.apache.org/r/50643/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message