mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 49862: Changed libmesos from static library to a shared library.
Date Tue, 02 Aug 2016 01:31:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144435
-----------------------------------------------------------




src/slave/cmake/SlaveConfigure.cmake (line 70)
<https://reviews.apache.org/r/49862/#comment210453>

    Oh. This is especially pertinent given that you seem to remove this line in #49874.


- Alex Clemmer


On July 19, 2016, 9:36 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8

>   3rdparty/http-parser/CMakeLists.txt.template 9a671973b754095e1de917f135a7deb978fb6eb6

>   src/CMakeLists.txt bde76f7840afe55f20d7551b3f7e5fe522f7f326 
>   src/master/cmake/MasterConfigure.cmake 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake ced57496970f1d7edf9e7e443b22d14d2ee948f0 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message