mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 49688: Added cmake build variables for mesos tests.
Date Tue, 02 Aug 2016 01:17:34 GMT


> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote:
> > src/tests/CMakeLists.txt, line 21
> > <https://reviews.apache.org/r/49688/diff/5/?file=1441338#file1441338line21>
> >
> >     It looks like at least some of the following tests are missing, and I don't
see them grep'ing the codebase. Rough guess: we should be including these in the relevant
test subdirectories? If this is the rationale, can we please add them all now? If this is
not the rationale, can we please leave a comment explaining?
> >     
> >     
> >     ```
> >       tests/common/command_utils_tests.cpp				\
> >       tests/common/http_tests.cpp					\
> >       tests/common/recordio_tests.cpp				\
> >       tests/containerizer/composing_containerizer_tests.cpp		\
> >       tests/containerizer/docker_containerizer_tests.cpp		\
> >       tests/containerizer/docker_spec_tests.cpp			\
> >       tests/containerizer/docker_tests.cpp				\
> >       tests/containerizer/external_containerizer_test.cpp		\
> >       tests/containerizer/isolator_tests.cpp			\
> >       tests/containerizer/launcher.cpp				\
> >       tests/containerizer/memory_test_helper.cpp			\
> >       tests/containerizer/mesos_containerizer_tests.cpp		\
> >       tests/containerizer/provisioner_appc_tests.cpp		\
> >       tests/containerizer/provisioner_backend_tests.cpp		\
> >       tests/containerizer/provisioner_docker_tests.cpp
> >     ```
> >     
> >     Also, though not a test, the following file also seems to be not listed here:
> >     
> >     ```
> >     slave/qos_controllers/load.cpp
> >     ```
> 
> Srinivas Brahmaroutu wrote:
>     I am a bit undecided to see if all the code under test be pulled into one CMakeLists
script. I think common files should make their way here but containerizer also has a main
routine. I need clarification how we handle multiple 'main' routines in a project? 
>     slave/qos_controllers should end up in a library right?

Just to follow up:

* I think it remains to be seen how important it is to split multiple test binaries into different
folders. In principle there is no particular reason not to, especially since they all depend
on the monolithic libmesos binary.
* `slave/qos_controllers` is actually included in the build of these tests in the AC build
system, so I think we should mirror that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review141822
-----------------------------------------------------------


On July 19, 2016, 9:35 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake build variables for mesos tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/cmake/MesosTestsConfigure.cmake caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf

>   src/tests/containerizer/CMakeLists.txt 41e792a2c9ec588d4897d60d012e67c606bbe601 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message