mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 50676: Check for unsigned integers in Resources::count().
Date Tue, 02 Aug 2016 00:33:28 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50676/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 5:33 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4892
    https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
-------

Resources::count() returns size_t, so the check needs to be for
unsigned integers.


Diffs
-----

  src/tests/resources_tests.cpp 06ccc0c6eb1ed248f1c1ceaedf5a0d85a422b49e 

Diff: https://reviews.apache.org/r/50676/diff/


Testing (updated)
-------

Tests passed (with `export CXXFLAGS="-Werror=sign-compare"`)


Thanks,

Anindya Sinha
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message