mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50491: Moved Network and NetworkProcess definitions into cpp file.
Date Mon, 01 Aug 2016 23:43:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50491/#review144396
-----------------------------------------------------------



Holding off on "Ship It!"-ing, for now.

Please update the description with the reason behind this patch.  (It can be very similar
to the wording in the previous patch, because these are all related refactorings.)


src/log/network.cpp (lines 32 - 33)
<https://reviews.apache.org/r/50491/#comment210422>

    Extra newline here please.



src/log/network.cpp (lines 83 - 85)
<https://reviews.apache.org/r/50491/#comment210421>

    You can inline these three lines.


- Joseph Wu


On July 27, 2016, 10:20 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50491/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Network and NetworkProcess definitions into log/network.cpp.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3d33ee722543c67d0aa72e1c72c578066832331a 
>   src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
>   src/log/network.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50491/diff/
> 
> 
> Testing
> -------
> 
> see the end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message