> On 八月 1, 2016, 10:39 p.m., Jiang Yan Xu wrote:
> > Can we keep add/subtract private? The fact they were added to save some redudant
work suggests their `private` nature. Otherwise what if people use `add` directly instead
of `+=`?
> >
> > Looks like they were changed to public just so it can be called from the free-standing
`convertJSON`, which is a private util method itself. We can just friend it right?
>
> Benjamin Mahler wrote:
> Making it private sounds good and having a friend sounds good.
Thanks Jinag Yan and Ben, I will follow up a patch later.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50568/#review144394
-----------------------------------------------------------
On 七月 29, 2016, 1:34 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50568/
> -----------------------------------------------------------
>
> (Updated 七月 29, 2016, 1:34 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a follow up action for MESOS-5919. Based on the patch of
> https://reviews.apache.org/r/50553/ and
> https://reviews.apache.org/r/50557/ , we should update -=/+= to
> subtract/add if the resource object is from resources object.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 88a9feabf66ed34e7e5b1c6cb7e831818e7f7883
> include/mesos/v1/resources.hpp 054ed00a03319ae5e350542add34f497eaf79152
> src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb
> src/v1/resources.cpp 3c85dc8aa8125962b44e60806ece83a7653d0dc7
>
> Diff: https://reviews.apache.org/r/50568/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
|