mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 50672: Added extra conditions for deciding when to create "NvidiaComponents".
Date Mon, 01 Aug 2016 22:13:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50672/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-5959
    https://issues.apache.org/jira/browse/MESOS-5959


Repository: mesos


Description
-------

A recent addition to ensure that 'NvidiaVolume::create()' ran as root
broke all non-root tests on GPU machines.  The reason is that we
unconditionally create this volume so long as we detect
'nvml.isAvailable()', which will fail now that we are only allowed to
create this volume if we have root permissions.

We fix this by adding the proper conditions to determine when / if we
should create this volume based on some combination of --containerizer
and --isolation flags.


Diffs
-----

  src/slave/containerizer/containerizer.cpp d66356de06394fe5a006cbf1947d4f9055e6d111 

Diff: https://reviews.apache.org/r/50672/diff/


Testing
-------

GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message