mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 50674: Stout: Enabled tests that pass on Windows.
Date Mon, 01 Aug 2016 21:27:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50674/
-----------------------------------------------------------

Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
-------

A large number of Stout test files are currently not being built on
Windows.  Many of these files contain tests for parts of Stout that have
already been ported, or require only trivial fixes to work (such as
removing `#include`s on Windows). A small minority of the tests contain
bugs that we should fix.

This commit will add these files to the build, fix some of the
trivially-fixable tests, and disable tests that are known to fail
because of bugs, including comments explaining why and links to JIRA
issues where appropriate.


Diffs
-----

  3rdparty/stout/include/stout/mac.hpp 91c4fdad350459b3e0bdf1744089e14ac883829a 
  3rdparty/stout/include/stout/os/windows/kill.hpp 0ddb3eeae3377688ad298a45c849c829c218890f

  3rdparty/stout/tests/CMakeLists.txt f85dc998e8ba5f8d727933373c3e14500d0bdfae 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/ip_tests.cpp 4d1f1c9a4dd35da2a21bef1349a662af44bb4ba1 
  3rdparty/stout/tests/mac_tests.cpp 1ff60cf5506c1855547400aa20107ec5086d8431 
  3rdparty/stout/tests/os/rmdir_tests.cpp ffe234baac305e26b5a29cffcdd310350d10167e 
  3rdparty/stout/tests/os_tests.cpp e67444077eae55fd25945b451164b5bcc37552b0 

Diff: https://reviews.apache.org/r/50674/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message