mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50626: Made the JSON snippets complete in Scheduler HTTP API doc.
Date Mon, 01 Aug 2016 16:56:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50626/#review144348
-----------------------------------------------------------



LGTM, just some minor nits around spacing issues.

Also, just to be sure did you validate if the JSON is correct?


docs/scheduler-http-api.md (line 44)
<https://reviews.apache.org/r/50626/#comment210359>

    Nit: Can you update the length here?



docs/scheduler-http-api.md (line 46)
<https://reviews.apache.org/r/50626/#comment210360>

    Not yours: Can you update this to being the `HEARTBEAT` event since it's always the second
event sent on the stream?



docs/scheduler-http-api.md (line 163)
<https://reviews.apache.org/r/50626/#comment210367>

    Space after `:`



docs/scheduler-http-api.md (line 164)
<https://reviews.apache.org/r/50626/#comment210368>

    Space after `:`



docs/scheduler-http-api.md (line 165)
<https://reviews.apache.org/r/50626/#comment210366>

    Space before/after `:`



docs/scheduler-http-api.md (line 167)
<https://reviews.apache.org/r/50626/#comment210361>

    Nit: s/Sleep/My Task to align more with the `task_id`.



docs/scheduler-http-api.md (line 436)
<https://reviews.apache.org/r/50626/#comment210363>

    Space before/after `:`



docs/scheduler-http-api.md (line 444)
<https://reviews.apache.org/r/50626/#comment210364>

    Space before/after `:`



docs/scheduler-http-api.md (line 451)
<https://reviews.apache.org/r/50626/#comment210365>

    Space before/after `:`



docs/scheduler-http-api.md (line 452)
<https://reviews.apache.org/r/50626/#comment210362>

    Can we use the same `executor_id` everywhere?


- Anand Mazumdar


On Aug. 1, 2016, 4:31 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50626/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-5790
>     https://issues.apache.org/jira/browse/MESOS-5790
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the JSON snippets complete in Scheduler HTTP API doc.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 
> 
> Diff: https://reviews.apache.org/r/50626/diff/
> 
> 
> Testing
> -------
> 
> Viewed the scheduler-http-api doc using rake dev
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message