mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 49351: Allowed other HealthCheck types in docker executor.
Date Mon, 01 Aug 2016 16:09:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49351/#review144327
-----------------------------------------------------------




src/docker/executor.cpp (line 453)
<https://reviews.apache.org/r/49351/#comment210350>

    s/require/requires



src/docker/executor.cpp (lines 465 - 469)
<https://reviews.apache.org/r/49351/#comment210356>

    Do you make this change because you think it is more readable?


- Alexander Rukletsov


On Aug. 1, 2016, 1:14 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49351/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 1:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, Jie Yu,
and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
>     https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed other HealthCheck types in docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
> 
> Diff: https://reviews.apache.org/r/49351/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message