mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 50644: Added check for root permissions to 'NvidiaVolume::create()'.
Date Mon, 01 Aug 2016 16:05:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50644/#review144340
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On July 31, 2016, 6:56 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50644/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5945
>     https://issues.apache.org/jira/browse/MESOS-5945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added check for root permissions to 'NvidiaVolume::create()'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 4b3651a8266b1ba193f6d207cd3be1ce55629703

>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 02d82e3e1ab3e7dd05f351a294774cf000276bcd

> 
> Diff: https://reviews.apache.org/r/50644/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*NVIDIA*" make -j check`
> 
> Also ran a master / agent locally on a GPU machine and made sure that the agent failed
without root on the proper error message.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message