mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 49555: Updated docker executor to use HealthCheck via library way.
Date Mon, 01 Aug 2016 10:19:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49555/#review144317
-----------------------------------------------------------



Thanks a lot for cleaning things up. Could you please test this patch and update the "testing
done" section? It would be great if you manually create some apps with health checks and make
sure they work (both succeed and fail paths).


src/docker/executor.cpp (line 501)
<https://reviews.apache.org/r/49555/#comment210340>

    do you need to `devolve` here?



src/docker/executor.cpp (line 503)
<https://reviews.apache.org/r/49555/#comment210341>

    do you need to `devolve` here?



src/docker/executor.cpp (line 506)
<https://reviews.apache.org/r/49555/#comment210342>

    Could you please create a JIRA ticket under the `HealthChecks` epic discussing introducing
an action on health check creation failure? Thanks!


- Alexander Rukletsov


On Aug. 1, 2016, 10:01 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49555/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 10:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, Jie Yu,
and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker executor to use HealthCheck via library way.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 2089b547408a46c9b4fa91e3ab17b88f7d2d8397 
> 
> Diff: https://reviews.apache.org/r/49555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message