mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50128: Added helpful functions to 'Docker::Device'.
Date Mon, 01 Aug 2016 08:20:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review144308
-----------------------------------------------------------




src/docker/docker.hpp (lines 72 - 74)
<https://reviews.apache.org/r/50128/#comment210320>

    ```
    Device(
        const std::string& host,
        const std::string& container,
        const std::string& permissions)
    ```



src/docker/docker.hpp (line 91)
<https://reviews.apache.org/r/50128/#comment210325>

    we perefer to put this `+` to the end of above line.
    
    ```
    return hostPath.string() + ":" + containerPath.string() +
           ":" + permissions;
    ```



src/docker/docker.hpp (line 95)
<https://reviews.apache.org/r/50128/#comment210326>

    s/std::vector<std::string> deviceInfo/const std::vector<std::string> deviceInfo



src/docker/docker.hpp (lines 97 - 98)
<https://reviews.apache.org/r/50128/#comment210323>

    We do not need period to the end and it is better add more detail for the error such as
the `device` string.
    
    ```
    LOG(INFO) << "Parse device information error for '" << device
              << "', PathInHost:PathInContainer:Permission expected";
    
    ```



src/docker/docker.cpp (lines 389 - 391)
<https://reviews.apache.org/r/50128/#comment210324>

    We prefer
    
    ```
    Device device = Device(
        hostPath->value,
        containerPath->value,
        permissions->value);
    ```


- Guangya Liu


On 七月 29, 2016, 9:52 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> -----------------------------------------------------------
> 
> (Updated 七月 29, 2016, 9:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wrapped helpful functions to 'Docker::Device' to
> handle string parsing and serializing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
> 
> Diff: https://reviews.apache.org/r/50128/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message