From reviews-return-41574-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jul 28 00:17:54 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE83419761 for ; Thu, 28 Jul 2016 00:17:54 +0000 (UTC) Received: (qmail 8302 invoked by uid 500); 28 Jul 2016 00:17:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 8268 invoked by uid 500); 28 Jul 2016 00:17:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8244 invoked by uid 99); 28 Jul 2016 00:17:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2016 00:17:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E3C5629FD80; Thu, 28 Jul 2016 00:17:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6543540341699666433==" MIME-Version: 1.0 Subject: Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp. From: Greg Mann To: Joris Van Remoortere , Artem Harutyunyan Cc: mesos , Greg Mann , Joseph Wu Date: Thu, 28 Jul 2016 00:17:52 -0000 Message-ID: <20160728001752.11792.99834@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40410/ X-Sender: Greg Mann References: <20160726211344.11791.92136@reviews.apache.org> In-Reply-To: <20160726211344.11791.92136@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6543540341699666433== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review143866 ----------------------------------------------------------- 3rdparty/libprocess/include/process/metrics/metrics.hpp (line 86) Single space between sentences? - Greg Mann On July 26, 2016, 9:13 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40410/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 9:13 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > The metrics singleton must be unified with `process::initialize` so > that it also falls under the scope of reinitialization. The singleton > must also not be guarded by `Once`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp 54487ab2614c7f8e8df10d1e0c39880a6cf5bde3 > 3rdparty/libprocess/src/metrics/metrics.cpp ac1544e70f5884f946ce3c31c5430c6a2c1f9dd1 > 3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 > 3rdparty/libprocess/src/tests/system_tests.cpp 0f4d0424689522337806ba2227ec4330c700e17e > > Diff: https://reviews.apache.org/r/40410/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > > --===============6543540341699666433==--