From reviews-return-41326-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 25 13:46:58 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 542BA1905C for ; Mon, 25 Jul 2016 13:46:58 +0000 (UTC) Received: (qmail 98880 invoked by uid 500); 25 Jul 2016 13:46:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 98851 invoked by uid 500); 25 Jul 2016 13:46:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 98835 invoked by uid 99); 25 Jul 2016 13:46:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jul 2016 13:46:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A674329F43C; Mon, 25 Jul 2016 13:46:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3970025862858420704==" MIME-Version: 1.0 Subject: Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`. From: Qian Zhang To: Jie Yu , Zhengju Sha , Gilbert Song , Qian Zhang Cc: haosdent huang , mesos Date: Mon, 25 Jul 2016 13:46:56 -0000 Message-ID: <20160725134656.11791.12239@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49814/ X-Sender: Qian Zhang References: <20160725023548.11792.66858@reviews.apache.org> In-Reply-To: <20160725023548.11792.66858@reviews.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============3970025862858420704== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/#review143375 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 82 - 86) I think besides preparing the hierarchy, we also need to ensure no other subsystem is attached to the hierarchy, see the following code as an example: https://github.com/apache/mesos/blob/1.0.0-rc4/src/slave/containerizer/mesos/isolators/cgroups/mem.cpp#L95:L105 Maybe you can do it in each subsystem's `load()` method. - Qian Zhang On July 25, 2016, 10:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49814/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 10:35 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::create`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49814/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============3970025862858420704==--