From reviews-return-41226-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jul 22 13:35:07 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C4C6198D7 for ; Fri, 22 Jul 2016 13:35:07 +0000 (UTC) Received: (qmail 50140 invoked by uid 500); 22 Jul 2016 13:35:07 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 50113 invoked by uid 500); 22 Jul 2016 13:35:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50098 invoked by uid 99); 22 Jul 2016 13:35:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 13:35:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E1EAF29F220; Fri, 22 Jul 2016 13:35:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5649260620569832373==" MIME-Version: 1.0 Subject: Review Request 50338: Fixed flakiness in SlaveAuthorizerTest.ViewFlags. From: Neil Conway To: Vinod Kone , Alexander Rojas Cc: Neil Conway , mesos Date: Fri, 22 Jul 2016 13:35:05 -0000 Message-ID: <20160722133505.15321.19245@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50338/ X-Sender: Neil Conway Reply-To: Neil Conway X-ReviewRequest-Repository: mesos --===============5649260620569832373== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50338/ ----------------------------------------------------------- Review request for mesos, Alexander Rojas and Vinod Kone. Bugs: MESOS-5888 https://issues.apache.org/jira/browse/MESOS-5888 Repository: mesos Description ------- Fixed flakiness in SlaveAuthorizerTest.ViewFlags. Diffs ----- src/tests/slave_authorization_tests.cpp f76ed3a4c77ba4109d1b9e2083bd3dfbfef41b43 Diff: https://reviews.apache.org/r/50338/diff/ Testing ------- `make check` Validated that with this change, slave recovery always finishes before any of the subsequent HTTP requests are sent. Note that I couldn't actually trigger the test case failure on my machine. If there's a more precise way to have the test case wait for the slave to finish recovery, let me know. Thanks, Neil Conway --===============5649260620569832373==--