From reviews-return-40855-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 18 22:16:26 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D479F194CA for ; Mon, 18 Jul 2016 22:16:26 +0000 (UTC) Received: (qmail 30003 invoked by uid 500); 18 Jul 2016 22:16:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29933 invoked by uid 500); 18 Jul 2016 22:16:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29859 invoked by uid 99); 18 Jul 2016 22:16:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2016 22:16:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F78327DF29; Mon, 18 Jul 2016 22:16:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9180826529673412407==" MIME-Version: 1.0 Subject: Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed. From: Guangya Liu To: Jie Yu , Klaus Ma , Benjamin Mahler , Jiang Yan Xu Cc: Mesos ReviewBot , Guangya Liu , mesos Date: Mon, 18 Jul 2016 22:16:26 -0000 Message-ID: <20160718221626.30914.70854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Guangya Liu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50115/ X-Sender: Guangya Liu References: <20160718033246.30913.86932@reviews.apache.org> In-Reply-To: <20160718033246.30913.86932@reviews.apache.org> Reply-To: Guangya Liu X-ReviewRequest-Repository: mesos --===============9180826529673412407== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/ ----------------------------------------------------------- (Updated 七月 18, 2016, 10:16 p.m.) Review request for mesos, Benjamin Mahler, Jie Yu, Klaus Ma, and Jiang Yan Xu. Repository: mesos Description ------- Currently, in HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave, we are using `sleep` to check if the operations are processed, this is not accurate, we should use `Clock::settle()` instead. Diffs (updated) ----- src/tests/hierarchical_allocator_tests.cpp 65c3fe6761ccb1ec7d5fbca9a78b2c62e11885ca Diff: https://reviews.apache.org/r/50115/diff/ Testing ------- make make check ``` [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 Using 1000 agents and 50 frameworks Added 50 frameworks in 14624us Added 1000 agents in 2.253886secs Updated 1000 agents in 1.940139secs [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 (4493 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (4495 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (4520 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu --===============9180826529673412407==--