From reviews-return-40274-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 12 02:01:37 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40D4A18D3A for ; Tue, 12 Jul 2016 02:01:37 +0000 (UTC) Received: (qmail 16311 invoked by uid 500); 12 Jul 2016 02:01:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16277 invoked by uid 500); 12 Jul 2016 02:01:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16255 invoked by uid 99); 12 Jul 2016 02:01:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 02:01:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF2AA2BD8E8; Tue, 12 Jul 2016 02:01:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8978514399607881546==" MIME-Version: 1.0 Subject: Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp. From: Guangya Liu To: Benjamin Mahler , Jiang Yan Xu Cc: Mesos ReviewBot , Guangya Liu , mesos Date: Tue, 12 Jul 2016 02:01:34 -0000 Message-ID: <20160712020134.30375.33560@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Guangya Liu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49781/ X-Sender: Guangya Liu References: <20160708061146.17622.46991@reviews.apache.org> In-Reply-To: <20160708061146.17622.46991@reviews.apache.org> Reply-To: Guangya Liu X-ReviewRequest-Repository: mesos --===============8978514399607881546== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49781/ ----------------------------------------------------------- (Updated 七月 12, 2016, 2:01 a.m.) Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Changes ------- Added dependency Bugs: MESOS-5800 https://issues.apache.org/jira/browse/MESOS-5800 Repository: mesos Description ------- This patch fixed the following issues in benchmark test: 1) Enabled emplatized test fixture for DeclineOffers and ResourceLabels. 2) Updated the output for the benchmark to be more clear. Diffs (updated) ----- src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb Diff: https://reviews.apache.org/r/49781/diff/ Testing ------- LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1” [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1 Using 1000 agents and 50 frameworks allocate() took 625869us to make 1000 offers allocate() took 628127us to make 1000 offers allocate() took 618838us to make 1000 offers allocate() took 595152us to make 1000 offers allocate() took 622273us to make 1000 offers allocate() took 595577us to make 1000 offers allocate() took 628503us to make 1000 offers allocate() took 623374us to make 1000 offers …. LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1” [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1 Using 1000 agents and 50 frameworks allocate() took 670083us to make 1000 offers allocate() took 665393us to make 1000 offers allocate() took 635591us to make 1000 offers allocate() took 691869us to make 1000 offers …. Thanks, Guangya Liu --===============8978514399607881546==--