From reviews-return-39981-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jul 9 23:30:17 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA89B197EF for ; Sat, 9 Jul 2016 23:30:17 +0000 (UTC) Received: (qmail 75055 invoked by uid 500); 9 Jul 2016 23:30:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75024 invoked by uid 500); 9 Jul 2016 23:30:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75011 invoked by uid 99); 9 Jul 2016 23:30:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jul 2016 23:30:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5A472B96D2; Sat, 9 Jul 2016 23:30:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0531351148820727477==" MIME-Version: 1.0 Subject: Re: Review Request 31142: MESOS-2364 - Docker containerizer should pull every time if image tag is ":latest" From: Joris Van Remoortere To: Joris Van Remoortere , Henning Schmiedehausen , mesos Date: Sat, 09 Jul 2016 23:30:15 -0000 Message-ID: <20160709233015.17622.17785@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/31142/ X-Sender: Joris Van Remoortere References: <20150218012600.21353.42335@reviews.apache.org> In-Reply-To: <20150218012600.21353.42335@reviews.apache.org> Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============0531351148820727477== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31142/#review141446 ----------------------------------------------------------- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Feb. 18, 2015, 1:25 a.m., Henning Schmiedehausen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31142/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 1:25 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2364 > https://issues.apache.org/jira/browse/MESOS-2364 > > > Repository: mesos > > > Description > ------- > > The "latest" tag for a docker image denominates the newest or most > recent version of a docker image. So the docker containerizer should > pull every time from the registry if the "latest" tag is encountered > to ensure that the most recent version is used. > > > Diffs > ----- > > src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28 > src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 > > Diff: https://reviews.apache.org/r/31142/diff/ > > > Testing > ------- > > > Thanks, > > Henning Schmiedehausen > > --===============0531351148820727477==--