From reviews-return-39284-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 4 18:15:59 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3689F19BC8 for ; Mon, 4 Jul 2016 18:15:59 +0000 (UTC) Received: (qmail 73727 invoked by uid 500); 4 Jul 2016 18:15:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 73698 invoked by uid 500); 4 Jul 2016 18:15:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 73678 invoked by uid 99); 4 Jul 2016 18:15:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jul 2016 18:15:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2B2F2B7C3B; Mon, 4 Jul 2016 18:15:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0829494444043251025==" MIME-Version: 1.0 Subject: Re: Review Request 49184: Implemented file volume support in mesos containerizer. From: Gilbert Song To: Timothy Chen , Jie Yu , Artem Harutyunyan , Jiang Yan Xu Cc: Gilbert Song , Guangya Liu , mesos Date: Mon, 04 Jul 2016 18:15:57 -0000 Message-ID: <20160704181557.17621.527@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49184/ X-Sender: Gilbert Song References: <20160626034236.14424.63458@reviews.apache.org> In-Reply-To: <20160626034236.14424.63458@reviews.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============0829494444043251025== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 25, 2016, 8:42 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 429 > > > > > > Just nit: What about adding a comment here, someone may be confused as when they saw that you only handled `file volume` for container with rootfs but not for containers without rootfs. > > > > // The container path can be either a directory or a > > // file. If the conainer path is a file here, the file > > // will be mounted as a volume to the container as well. > > Gilbert Song wrote: > Thanks! I will address it. I decided to move this comment above since it is for all cases. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review139473 ----------------------------------------------------------- On July 4, 2016, 10:40 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49184/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 10:40 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Bugs: MESOS-5697 > https://issues.apache.org/jira/browse/MESOS-5697 > > > Repository: mesos > > > Description > ------- > > Implemented file volume support in mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp adacde191132a7a92c1fdf27ef8a4a41d2afa003 > > Diff: https://reviews.apache.org/r/49184/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > > --===============0829494444043251025==--