mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.
Date Fri, 08 Jul 2016 21:12:26 GMT
Yan can you review this?

On Fri, Jul 8, 2016 at 11:53 AM, Mesos ReviewBot <reviews@mesos.apache.org>
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49781/
>
> Patch looks great!
>
> Reviews applied: [49781]
>
> Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
>
>
> - Mesos ReviewBot
>
> On July 8th, 2016, 6:11 a.m. UTC, Guangya Liu wrote:
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> By Guangya Liu.
>
> *Updated July 8, 2016, 6:11 a.m.*
> *Bugs: * MESOS-5800 <https://issues.apache.org/jira/browse/MESOS-5800>
> *Repository: * mesos
> Description
>
> This patch fixed the following issues in benchmark test:
> 1) Enabled emplatized test fixture for DeclineOffers and
> ResourceLabels.
> 2) Updated the output for the benchmark to be more clear.
>
> Testing
>
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1
> Using 1000 agents and 50 frameworks
>  allocate() took 625869us to make 1000 offers
>  allocate() took 628127us to make 1000 offers
>  allocate() took 618838us to make 1000 offers
>  allocate() took 595152us to make 1000 offers
>  allocate() took 622273us to make 1000 offers
>  allocate() took 595577us to make 1000 offers
>  allocate() took 628503us to make 1000 offers
>  allocate() took 623374us to make 1000 offers
> ….
>
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1
> Using 1000 agents and 50 frameworks
>  allocate() took 670083us to make 1000 offers
>  allocate() took 665393us to make 1000 offers
>  allocate() took 635591us to make 1000 offers
>  allocate() took 691869us to make 1000 offers
> ….
>
> Diffs
>
>    - src/tests/hierarchical_allocator_tests.cpp
>    (0498cd5e54b0e4b87a767585a77699653aa52179)
>
> View Diff <https://reviews.apache.org/r/49781/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message