mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 50520: Tweaked agent logging.
Date Sun, 31 Jul 2016 14:40:26 GMT


> On July 29, 2016, 7:30 p.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 198
> > <https://reviews.apache.org/r/50520/diff/1/?file=1455443#file1455443line198>
> >
> >     hmm, why this change?

Well, there has been an obvious typo in the output for a long time:

```
Agent started on 1)@192.168.0.101:5051
```

But I decided to restore this log line and remove a different, redundant log line that has
less information.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50520/#review144163
-----------------------------------------------------------


On July 27, 2016, 5:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50520/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tweaked agent logging.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50520/diff/
> 
> 
> Testing
> -------
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message