mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).
Date Sat, 30 Jul 2016 17:36:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review144266
-----------------------------------------------------------




support/mesos-style.py (line 20)
<https://reviews.apache.org/r/50629/#comment210263>

    I think we forgot update this since we update bundle dependencies last time. May you post
this in a sperate patch? Need update according to current `*.tar.gz` under `3rdparty`.


- haosdent huang


On July 30, 2016, 5:26 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50629/
> -----------------------------------------------------------
> 
> (Updated July 30, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Deshi Xiao.
> 
> 
> Bugs: MESOS-5186
>     https://issues.apache.org/jira/browse/MESOS-5186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix updated the requirement in `python/interface/setup.py.in`
> so that protobuf 3.0 is allowed.
> 
> 
> Diffs
> -----
> 
>   src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50629/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message