mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.
Date Sat, 30 Jul 2016 16:28:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50627/#review144262
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 209)
<https://reviews.apache.org/r/50627/#comment210261>

    Hi, @jieyu. I feel these code are duplicated, should we create a util method in `collect.hpp`?
    
    And for `discarded` future, we don't know which `Subsystem` it belongs to, should we make
it include the `Subsytem` name here?


- haosdent huang


On July 30, 2016, 4:24 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50627/
> -----------------------------------------------------------
> 
> (Updated July 30, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to get the error message for each subsystem, this patch
> changes to use `await` on `Subsystem` operations and combines every
> unready `Future` error message.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp bd20631a9650cf84e99c6489b2e92bc40ed764ca

> 
> Diff: https://reviews.apache.org/r/50627/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message