mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 50625: Renamed the filter for tests that depend on "perf".
Date Sat, 30 Jul 2016 09:50:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50625/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Previously, any test case that had "Perf" in its name would only be run
when the perf(1) command was installed. This is inconsistent with other
name-based filters for test cases (e.g., "ROOT_" or "CGROUPS_"). It also
meant that the filter matched "Registrar_BENCHMARK_Test.Performance",
which was a bug (the test does not depend on perf).

Instead, use "PERF_" to indicate tests that can only be run when perf(1)
is installed.


Diffs
-----

  src/tests/containerizer/cgroups_tests.cpp d766f0f0bfabd87904311d36f69aedf7651415b6 
  src/tests/containerizer/isolator_tests.cpp 488747347f71a6a1bb6bc01477143d077d4fd3eb 
  src/tests/containerizer/perf_tests.cpp 3dc5b0fa90dd941408a73585197b5309e3204576 
  src/tests/environment.cpp 0d22c4be42e2c3c53b2370be0c11544aea55621b 
  src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 

Diff: https://reviews.apache.org/r/50625/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message