mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50247: Added a abstract base class for scheduler library.
Date Sat, 30 Jul 2016 02:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50247/
-----------------------------------------------------------

(Updated July 30, 2016, 2:26 a.m.)


Review request for mesos, Joris Van Remoortere and Vinod Kone.


Changes
-------

Addressed review comment. NNFR


Repository: mesos


Description
-------

This change adds an abstract base class `MesosBase` that
would be used by implementations for interacting with
Mesos via the Scheduler API. This is needed later for
implementing the V0->V1 Scheduler Adapter.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/gtest.hpp 80d26db7710438115f5dff9a0505a5ec22b68648 
  3rdparty/libprocess/include/process/process.hpp 54c7d2e7ed3923ab15ab86e36552b023f9de5215

  3rdparty/libprocess/include/process/ssl/gtest.hpp 83778bbfcc75f3f39b98d03a3580398e7d1062ea

  3rdparty/libprocess/src/help.cpp d3c98a7ea94299ef6eb27062233191a380166526 
  3rdparty/libprocess/src/openssl.hpp f33614c82cefbf1c74a74ba9b3fa02105d0bec5b 
  3rdparty/libprocess/src/openssl.cpp a73313b3221d6c80b35f21c00f35d9f9c795f1ec 
  3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 
  3rdparty/libprocess/src/tests/main.cpp 023b4fe33a30cd3459d5ec2234a0f44bc736de92 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 4ddd35b61f222ca674e41875a6d0ee43d12cbfbd

  3rdparty/libprocess/src/tests/profiler_tests.cpp 995bd02f6ecce484cd9b2aca355c2707d73d40b2

  3rdparty/libprocess/src/tests/ssl_client.cpp dffd9ffa9e57fccf6e25207e163bea5803b65255 
  3rdparty/libprocess/src/tests/ssl_tests.cpp a5ac03969694c4345c2c5004051b08b6d1da8555 
  3rdparty/stout/include/stout/uuid.hpp e638d458c6cb4aaee121a903bb381ccfdeae3fad 
  3rdparty/stout/tests/uuid_tests.cpp 8f28fcf491e43e87ddd5b54737fd5aef0f6db0a6 
  CHANGELOG 54b5f316e5ccc175cc3f471681b02e677499317d 
  docs/app-framework-development-guide.md b419cb4a2cc85cb903af91378d7291e4966bb879 
  docs/authentication.md 1574db981d5f8ddd7d1f6bef1c2b032823d17297 
  docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
  docs/endpoints/files/browse.json.md 55ee41b1d61f46a11931a9e9d9b1e4f65f0d80ce 
  docs/endpoints/files/browse.md de8632e95373e2719bc9a035a82ed51f1c9b0437 
  docs/endpoints/files/debug.json.md a4dc0de5f343a799bdba983b4e75ee106b0bf64b 
  docs/endpoints/files/debug.md 9361ffecef4a1cab1138981c5ce302561505cfda 
  docs/endpoints/files/download.json.md 88dd72cbd97845fe8e9a3bdd374502b91d7712bd 
  docs/endpoints/files/download.md 3a3876010e0f5c55826b20c5176b6f82f3249deb 
  docs/endpoints/files/read.json.md 6697ab1e251c22db8a7b79926d737fad9514249d 
  docs/endpoints/files/read.md 21ea6d8a3b9a2bd7cfc214653048a9f74bbac91c 
  docs/endpoints/master/api/v1.md 19c6142844ee9167f532496873524508d335a59d 
  docs/endpoints/master/api/v1/scheduler.md 39cd457efd144ce316e8c13c916000cac8e51ad7 
  docs/endpoints/master/create-volumes.md f6ec9384f7f2bfb8056e54532ac3417a1f15b1d1 
  docs/endpoints/master/destroy-volumes.md 054e816371f26c91ccc0d9687f377e80641e42a8 
  docs/endpoints/master/flags.md 850b6f86ddd92af512932aec5af9bdc600cf92d8 
  docs/endpoints/master/frameworks.md 1aed723152528be0e19d79520daac5f470cb49da 
  docs/endpoints/master/reserve.md 9bb04ed0de5b9304301fffd51b39ec07102825cd 
  docs/endpoints/master/state-summary.md 4eb517ea0f6b5dbc2e7d7c406d54e741cf50e0e5 
  docs/endpoints/master/state.json.md c5852bd01dd5f72a9a11991a033d8c97b111ad21 
  docs/endpoints/master/state.md 8e0650f84ae13ef7952971ffb9732ec379cffd40 
  docs/endpoints/master/tasks.json.md 5d2c0e6eb53fa5e04a973eb786cd16bfad38736f 
  docs/endpoints/master/tasks.md c7df686443e20d255b03fc31a999b9b24b5f3a0a 
  docs/endpoints/master/teardown.md 4c14f594c3713304d5adf59e56e9e8af2b05ebee 
  docs/endpoints/master/unreserve.md 5cce4288231a64d7ee7713f2b44487618e7cc0a7 
  docs/endpoints/slave/api/v1.md c867d795104e053e5aae819df3deea68269228bf 
  docs/endpoints/slave/flags.md 3ea38c160670fc302a42ae98d7ebe0679b5bdc92 
  docs/endpoints/slave/state.json.md ac8536986ceb6532f71b4fe1c62b1b83390b03e7 
  docs/endpoints/slave/state.md c7b61d736582f50b850fed252e558bbae6dad801 
  docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
  docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
  docs/powered-by-mesos.md 64e55e1bdaf6d045bb79ea80aed3171b3ee73900 
  docs/ssl.md 2f7d928ef94b9fb611e071b01755c002554bad40 
  docs/upgrades.md d3e7cdd51b4c294ef49447595d9cb074c5a993fe 
  include/mesos/resources.hpp 88a9feabf66ed34e7e5b1c6cb7e831818e7f7883 
  include/mesos/v1/resources.hpp 054ed00a03319ae5e350542add34f497eaf79152 
  include/mesos/v1/scheduler.hpp 18e7a95f8342ea155f9e339945b05810b6bd82b5 
  site/source/assets/js/dev-community.js e2686e2b2caddf6b798e37491c3d5f8879ec374c 
  site/source/blog/2016-07-21-dev-community-status.md 8a8b0e3509c550c4d0342e36e9ca02214f7144d8

  site/source/layouts/basic.erb 253de38a53a2dd42f859af5fd0da92786c93a0b2 
  site/source/layouts/dev-community.erb 950d6433db4d17976378b68c0012b5df410361c0 
  src/authorizer/local/authorizer.cpp e410cc5742441b120b3addbf5789ce96a19af388 
  src/common/http.hpp 145f64b5f2101904880263c8d82f9d0852548ff6 
  src/common/http.cpp 65e73235a95c1129a7e51a64077eb6ed2aee4a4b 
  src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb 
  src/common/values.cpp cc87d9436f1a75e71cbeb8b709ec323e24f4f519 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
  src/files/files.cpp 793d68ec700c792fc9dd73b09ee2616108b88f4f 
  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/java/src/org/apache/mesos/SchedulerDriver.java 85faa8e6f8b3420ce140eff7ac860a5f3d417928

  src/launcher/executor.cpp b775931cdb5e0d55acdf01c309864165bf70d12f 
  src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
  src/linux/ns.hpp e905aefe5ab178c8471cfe801e6432540d3dea67 
  src/local/local.cpp d6fe4d01cfe12375be00a1d26a5ad7420e029c16 
  src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
  src/master/constants.hpp cd80dace80968a1f67a8de5b2c112fb1396e26aa 
  src/master/flags.hpp c6e85303f60387f42b5e187eaedb6a01000f948f 
  src/master/flags.cpp 19ae6c1c30a1054b64a9585f325bd0bf943af218 
  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
  src/slave/constants.hpp 360dd059b21ae3128766ba7abdbffb36d4c3ec13 
  src/slave/containerizer/mesos/containerizer.cpp 86a8d8a85b6a33c87798108cb65af85bb9bbbc77

  src/slave/containerizer/mesos/isolators/appc/runtime.cpp e8fe131e355796d450dd4d823a6be4e4e4ec4506

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 348f105f9c3109a02f1dde0649f1b829cb9ddd04

  src/slave/containerizer/mesos/provisioner/appc/store.cpp c27b1b5ca05a5883831c86575ac129903e758598

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 8f378f6fea3fa4b6d1b7d079c7f280790b30589e

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a

  src/slave/containerizer/mesos/provisioner/store.hpp a312ad953b406aa75506051593dcc1c27cdc93af

  src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 
  src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
  src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
  src/slave/status_update_manager.cpp 9d16e0da92fdf2970ad3fd62036f6c5432eed774 
  src/tests/api_tests.cpp 88523fdb3469c40b7ff71d5d753b645d20bc51bd 
  src/tests/cluster.hpp c6fbbf24e04c38cc9a94ce0c13db445c03e804c7 
  src/tests/cluster.cpp dd415446a89f1a398df0396afc247621ebc90c9f 
  src/tests/containerizer/cni_isolator_tests.cpp 0d611c196870b6adabea52a48abcd344c8dad5d1

  src/tests/dynamic_weights_tests.cpp 88565d19146c9f8fc26808a62e4a67ced1b2a5f3 
  src/tests/fetcher_tests.cpp aea0900e2296e826d9769adba6f347d6277caa37 
  src/tests/hierarchical_allocator_tests.cpp bb6947fcecb5b78047e98d10fc1278c612a69548 
  src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f 
  src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
  src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
  src/tests/mesos.hpp 51c66f175c80ebacd5af230222ea7e4c81dfc1e8 
  src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65 
  src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
  src/tests/persistent_volume_endpoints_tests.cpp 266c2a0ff4a99baa96a7c4980f076755603256a9

  src/tests/reservation_endpoints_tests.cpp bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 
  src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a 
  src/tests/sorter_tests.cpp ade356cbbba5b93a6d3e5c9de30eefd3982d15c1 
  src/v1/resources.cpp 3c85dc8aa8125962b44e60806ece83a7653d0dc7 
  src/v1/values.cpp 6e3617ef8cce1b89632d9266878914e472e069b1 

Diff: https://reviews.apache.org/r/50247/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message